This pull request introduces a few improvements and fixes related to API routing, endpoint metadata, and test data. The most significant changes are adjustments to the way the products API router is imported and included, an update to the root endpoint's metadata, and the addition of a new CSV test file.#19
Merged
goldlabelapps merged 2 commits intomasterfrom Mar 23, 2026
Merged
This pull request introduces a few improvements and fixes related to API routing, endpoint metadata, and test data. The most significant changes are adjustments to the way the products API router is imported and included, an update to the root endpoint's metadata, and the addition of a new CSV test file.#19goldlabelapps merged 2 commits intomasterfrom
products API router is imported and included, an update to the root endpoint's metadata, and the addition of a new CSV test file.#19goldlabelapps merged 2 commits intomasterfrom
Conversation
Update package version from 1.0.7 to 1.0.8 in app/__init__.py. Add tests/csv/small.csv containing a header and several sample product rows (params, item, descriptions, pricing, EANs) for CSV-related tests.
Refactor products module into a package (app/api/products/products.py) and add app/api/products/__init__.py to re-export the router. Update app/api/routes.py to import the router from the new location. Also fix a typo in app/api/root.py: use the consistent "name" key for the docs endpoint in the root endpoints list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API Routing and Import Fixes:
productsrouter inapp/api/routes.pyto usefrom app.api.products.products import router as products_router, ensuring the correct module is referenced.routerinapp/api/products/__init__.pyto facilitate cleaner and more predictable imports.Endpoint Metadata and Versioning:
"name"instead of"docs"for consistency in the endpoints list.1.0.7to1.0.8inapp/__init__.py.Testing Improvements:
tests/csv/small.csv) containing product data for use in tests or development.