Fetch according to geo coordinates

[kazuar]

Ability to fetch articles using geo coordinates

[goldsmith]

add documentation for article_name

[kazuar]

1. Added documentation for article_name
2. Used article_name in the search parameters instead of checking it with returned results.
3. Removed all log/print statements
4. coordinates property returns a tuple of decimals in the format of (lat, lon)

[goldsmith]

typo

[goldsmith]

still need a little more insight into the data structures here:

• can you link to the Mediawiki documentation page on geocordinates in a comment?
• what's in coordinates[1:]?

also, by "decimal" I meant the python Decimal type, as in:

from decimal import Decimal

one = Decimal("1.00")

Decimal objects are the preferred format for lat/lon over floats and strings because of their precision and methods.

[goldsmith]

Almost there, thanks for correcting all of the minor details. One bigger thing left: tests! If you check the tests folder, you can see other examples of mocked out HTTP response data to make sure that Wikipedia is still parsing and returning things correctly if we ever decide to refactor.

Looking forward to merging after we have tests for geo coordinates!

[kazuar]

1. Added the unit tests (forgot about these initially :))
2. The link to the mediawiki is http://www.mediawiki.org/wiki/Extension:GeoData
3. Doesn't seem to be anything after the first coordinates results (coordinates[1:]). Maybe there are pages with multiple geo coordinates but I'm not sure.
4. I've changed the coordinates results to be a tuple of Decimals objects (Decimal, Decimal).

[goldsmith]

what's the purpose of doing this instead of just importing decimal and testing if the Decimal objects are equal?

[kazuar]

Mostly because I don't really trust decimals.
I can change it if it's an issue.

When do you think that we can merge the new feature?

[goldsmith]

Sorry, it looks great. This week is pretty busy for me, so I'll merge it in this weekend

[kazuar]

no worries :).
This is my first contribution so I kinda wanted to make it right.
Thanks and let me know if I can help in any way.

[kazuar]

Mostly because I don't really trust decimals.
I can change it if it's an issue.

[goldsmith]

I renamed search_loc to geosearch, just FYI. Thanks so much for your work on this pull request! I'll work on pushing v1.2 of wikipedia out to pip.

[kazuar]

Thank you.
Let me know if there's anything I can do to help.
It was really fun working with you on this.