add categories attribute to Wikipedia page#59
Conversation
|
looks great! can you add a unit test for this so we can make sure it isn't broken with subsequent releases? see the tests folder for style and how we mock out Mediawiki API response data. |
|
Ok, I added a test_categories method based on the test_links method. |
|
looks great, thanks! now that I think about it, it also would probably make sense to strip away the 'Category:' prefix from the categories in the list before returning to the user - do you think you could make that change too? |
|
Yes, I can. On Tue, Aug 19, 2014 at 5:00 PM, Jonathan Goldsmith <
Will |
add categories attribute to Wikipedia page
|
sorry for the delay, thanks for your work! |
This adds a new categories attribute to WikipediaPage, based on the similar code for links.