Fixes #1302 : Updated validation for API name with special characters#1303
Fixes #1302 : Updated validation for API name with special characters#1303afsalthaj merged 11 commits intogolemcloud:mainfrom 0xvasanth:fix/1302
Conversation
|
Could you please make the build green? |
|
Hi! As the feedback loop is a bit slow because you are a first contributor and I have to click on an approve button here for each attempt :) I just wanted to mention make sure you:
there are some flaky worker executor tests that may randomly fail, I'll restart your CI run when that happens. |
Hi @vigoo , Thanks for helping me out, I have executed all the command which you have mention, but will do it one more time in same order in which you have specified and will get back to you |
|
@vigoo you have missed two more command which run the test case
since I am facing error in integration testing GitHub-action |
Signed-off-by: itsparser <itsparser@gmail.com>
|
@vigoo I have tested it locally can you approve that it now |
Resolves #1302
What have been fixed
Validation Logic Update:
• Updated the input validation for API names to accept only alphanumerical characters, hyphens, and underscores.
• Extended similar validation to Worker names to prevent future issues when users set custom names.
User Feedback Improvement:
Enhanced error messaging in the Cloud Console to inform users of the acceptable character set when an invalid name is entered.
Resource Accessibility:
Prevented the creation of APIs (and Workers) with invalid names, ensuring that all created resources remain accessible for subsequent editing and deletion.
Testings
Manual Testing:
Valid Name Creation:
Created APIs with valid names (e.g., "test_api", "test-api", "Test123") to confirm that resources are created successfully and remain accessible.
Invalid Name Rejection:
Attempted to create APIs using names with special characters (e.g., "test;;", "test:api", "test/api"), verifying that the console correctly blocks these names and displays an appropriate error message.