Skip to content

agent-config: add support for agent config to cli/manifest and make naming in the api more consistent#2958

Merged
mschuwalow merged 2 commits intomainfrom
agent-config-manifest
Mar 16, 2026
Merged

agent-config: add support for agent config to cli/manifest and make naming in the api more consistent#2958
mschuwalow merged 2 commits intomainfrom
agent-config-manifest

Conversation

@mschuwalow
Copy link
Contributor

@mschuwalow mschuwalow commented Mar 10, 2026

resolves #2803
resolves #2818

Wit naming will be updated as part of next pr as that one will need to touch wit anyway

manifest will look like this:

secretDefaults:
   local:
      - path: [ "secret" ]
        value: "a"
      - path: [ "nested", "nestedSecret" ]
        value: 1

components:
  golem-it:agent-sdk-ts:
    templates: ts
    agents:
       ConfigAgent:
          config:
          - path: [ "foo" ]
            value: 1
          - path: [ "bar" ]
            value: "bar"
          - path: [ "nested", "a" ]
            value: true
          - path: [ "nested", "b" ]
            value: [1, 2, 3]
          - path: [ "aliasedNested", "c" ]
            value: 1

@mschuwalow mschuwalow force-pushed the agent-config-manifest branch from 8487800 to c685564 Compare March 10, 2026 19:07
@mschuwalow mschuwalow self-assigned this Mar 10, 2026
@mschuwalow mschuwalow force-pushed the agent-config-manifest branch 2 times, most recently from e85bfbd to a27dcd0 Compare March 10, 2026 22:01
@mschuwalow mschuwalow force-pushed the agent-config-shared-config-worker-executor branch from 457c1f3 to ec0dcb2 Compare March 11, 2026 17:10
Base automatically changed from agent-config-shared-config-worker-executor to main March 13, 2026 14:48
@mschuwalow mschuwalow force-pushed the agent-config-manifest branch from a27dcd0 to b5353cc Compare March 13, 2026 16:38
/// wasi:config entries visible for the agent
#[arg(short, long, value_parser = parse_key_val, value_name = "VAR=VAL")]
config_vars: Vec<(String, String)>,
/// agent config for entries
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a very understandable help string

))
}

fn parse_worker_agent_config(s: &str) -> anyhow::Result<WorkerAgentConfigEntry> {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe these parsing functions with their corresponding tests could live in a small submodule in a different file, this one is getting huge

Copy link
Contributor

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments, otherwise looks good

@mschuwalow mschuwalow requested a review from vigoo March 16, 2026 11:07
@mschuwalow mschuwalow merged commit da8effb into main Mar 16, 2026
29 checks passed
@mschuwalow mschuwalow deleted the agent-config-manifest branch March 16, 2026 12:14
@github-actions github-actions bot locked and limited conversation to collaborators Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adjust the cli/manifest to allow managing defaults for secrets Expose agent-type specific local configuration in the golem manifest

2 participants