agent-config: add support for agent config to cli/manifest and make naming in the api more consistent#2958
Merged
mschuwalow merged 2 commits intomainfrom Mar 16, 2026
Merged
Conversation
8487800 to
c685564
Compare
e85bfbd to
a27dcd0
Compare
457c1f3 to
ec0dcb2
Compare
Base automatically changed from
agent-config-shared-config-worker-executor
to
main
March 13, 2026 14:48
…aming in api more consistent
a27dcd0 to
b5353cc
Compare
vigoo
reviewed
Mar 16, 2026
cli/golem-cli/src/command.rs
Outdated
| /// wasi:config entries visible for the agent | ||
| #[arg(short, long, value_parser = parse_key_val, value_name = "VAR=VAL")] | ||
| config_vars: Vec<(String, String)>, | ||
| /// agent config for entries |
Contributor
There was a problem hiding this comment.
This is not a very understandable help string
vigoo
reviewed
Mar 16, 2026
cli/golem-cli/src/command.rs
Outdated
| )) | ||
| } | ||
|
|
||
| fn parse_worker_agent_config(s: &str) -> anyhow::Result<WorkerAgentConfigEntry> { |
Contributor
There was a problem hiding this comment.
Maybe these parsing functions with their corresponding tests could live in a small submodule in a different file, this one is getting huge
vigoo
requested changes
Mar 16, 2026
Contributor
vigoo
left a comment
There was a problem hiding this comment.
Two small comments, otherwise looks good
vigoo
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #2803
resolves #2818
Wit naming will be updated as part of next pr as that one will need to touch wit anyway
manifest will look like this: