Implement language-conditional fields, invoke_json step, and close invoke (#2883, #2890, #2891)#3116
Merged
vigoo merged 3 commits intoimplement-missing-harness-issuesfrom Apr 10, 2026
Conversation
…oke_json step (#2891) - Add resolveByLanguage() for fields that accept either a plain value or a {ts: ..., rust: ...} map. Applied to prompt, expectedSkills, allowedExtraSkills, and verify fields. - Add invoke_json step type that runs golem --format json agent invoke and evaluates result_json assertions with JSONPath. - Add INVOKE_JSON_FAILED classification. - #2890 (invoke step) was already implemented. Closes #2883, closes #2890, closes #2891
vigoo
reviewed
Apr 7, 2026
Integrate invoke_json action type from fix-harness-issues-2883-2890-2891 into the clean separated type system from implement-missing-harness-issues: - Add InvokeJsonStep variant and parseStep case - Add invoke_json to substituteStepVariables and executeStepBody switches - Handle LangConditional<T> types in StepCommon for language-conditional fields - Add subLangStr helper for substituting in lang-conditional string values
vigoo
merged commit 20350b6
into
implement-missing-harness-issues
43 of 45 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
prompt,expectedSkills,allowedExtraSkills, andverifynow accept either a plain value or a{ts: ..., rust: ...}map that resolves based on the current execution languageinvoke_jsonstep type — runsgolem --format json agent invokeand evaluatesresult_jsonassertions with JSONPathexecuteInvokeexists with full assertion support (stdout_contains,stdout_matches,exit_code,result_json)Verified locally
golem agent invoke— confirmed working with PascalCase agent namesgolem --format json agent invoke— returns structured JSON withresult_jsonfieldgolem agent delete— confirmed workingTest plan
Closes #2883, closes #2890, closes #2891