Transient error handling and concurrency limit for postgres based indexed storage#3184
Merged
Conversation
noise64
reviewed
Apr 15, 2026
| let level = self.level; | ||
| let key = Self::compressed_oplog_key(&owned_agent_id.agent_id); | ||
| retry_storage_op(&self.retry_config, "compressed_exists", &key, || { | ||
| let is = is.clone(); |
Contributor
There was a problem hiding this comment.
not that it matters much, but do we have to also clone on line 141?
noise64
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The oplog layer was intentionally
.expectthe indexed storage operations because we wanted to the executor to stop running as soon as it stopped being able to access the oplog, to minimize effects of a split-brain scenario, for example.While checking failed benchmark logs I noticed that with the switch to postgres-based indexed storage implementation, now we can easily overload the sqlx pool with many parallel agents, and that manifests in pool timeout errors that are also treated as such critical issue and crashes the executor.
We should not crash the executor just because it is overloaded; this PR introduces a few things to avoid that: