Skip to content

Plugin fixes#3250

Merged
vigoo merged 3 commits intomainfrom
plugin-fixes
Apr 23, 2026
Merged

Plugin fixes#3250
vigoo merged 3 commits intomainfrom
plugin-fixes

Conversation

@vigoo
Copy link
Copy Markdown
Contributor

@vigoo vigoo commented Apr 22, 2026

  • builtin plugins have a fix version so server updates are not going to break deployments
  • golem plugin list lists not only own, but shared plugins too (including builtins)
  • plugin diff fix
  • if plugin referenced in the manifest is not found, give a proper error message instead of a panic
  • example docker compose for trying out the otlp plugin

@vigoo vigoo linked an issue Apr 22, 2026 that may be closed by this pull request
{
// Oplog processor plugin logs are emitted into the server log because
// they cannot be easily watched with CLI tools.
if self.state.component_metadata.metadata.has_oplog_processor() {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something we want in prod?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more detailed answer: there is no other way to see what these plugins are doing at the moment. they are not real agents so no cli command works on them, etc.
i think having them able to log into the server log is a good enough solution for now

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant that in cloud user defined code can pollute our service logs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but I think for now that is better than not being able to see anything. We definitely need better observatibility tools for the plugins!

@vigoo vigoo merged commit 6f7717c into main Apr 23, 2026
94 of 95 checks passed
@vigoo vigoo deleted the plugin-fixes branch April 23, 2026 06:27
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Built-in plugin grant does not work with local golem

2 participants