Do not run scheduled invocations for deleted / recreated agents#3320
Merged
Conversation
mschuwalow
changed the title
mschuwalow
force-pushed
the
scheduling-deleted-workers
branch
from
e2f0dfa to
adda9ab
Compare
vigoo
reviewed
May 4, 2026
| /// Some entry types (e.g. `AgentInvocationStarted`) cannot be losslessly | ||
| /// round-tripped because the public representation discards internal detail. | ||
| /// For those cases this conversion returns an error. | ||
| impl TryFrom<PublicOplogEntry> for OplogEntry { |
Contributor
There was a problem hiding this comment.
I think this was supposed to replace the similar, older function in debugging-service (debug_session.rs), we just failed to delete that one during the oplog refactoring.
I would like to keep this and remove that so all the conversions stay in golem-common where the types are defined
Contributor
|
are you going to remove the other one now that the golem-common part was added back? |
Contributor
Author
Yes, but I would prefer to do that in a separate pr |
vigoo
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #3293