Ephemeral agent listing fixes#3671
Merged
Merged
Conversation
✅ Deploy Preview for golemcloud canceled.
|
noise64
reviewed
Jun 29, 2026
| let mut workers = Vec::<AgentMetadata>::new(); | ||
| let mut final_result_cursor = Option::<ScanCursor>::None; | ||
|
|
||
| // When a structured mode overlay is provided (--mode all), the string |
Contributor
There was a problem hiding this comment.
Can we unify the with and without mode_overlay cases (or always use just the more powerful)? It feels a bit duplicated this way with the repeated loop / cursor handling
noise64
approved these changes
Jun 29, 2026
noise64
left a comment
noise64
left a comment
Contributor
There was a problem hiding this comment.
Look good, added a minor comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3431
Adds several tests and fixes two problems:
--mode allwas not listing durable+ephemeral (only durable)