Suspend and Resume#118
Conversation
bump the minor version to 0.3
| self._startup_finished = True | ||
|
|
||
| async def start(self): | ||
| async def start(self, resume=False): |
There was a problem hiding this comment.
I would prefer start, _create_networks and _start_service with resume=True to be separated methods. e.g. resume, _resume_networks and _resume_service.
This would limit the number of times resume arg is passed around and frequency of resume being checked in if statements.
I also wonder if resume realy is an options of exciting start command or should it be a separated command.
There was a problem hiding this comment.
as you can see there's still considerable overlap in the logic that happens nevertheless when executing those steps, so in my opinion "resume" still seems like a mode of starting the runner rather than a completely separate operation...
otherwise, we'll have to pull the logic to a larger number of internal methods, which will make the code more complicated...
so while I don't right out disagree with you, I feel specifying resume as a flag of the binary and a parameter of the various functions that start the components is reasonable and don't see strong arguments to separate them completely...
2 participants
No description provided.