Conversation
filipgolem
approved these changes
Jun 16, 2021
yapapi/log.py
Outdated
Comment on lines
+73
to
+75
| """Format datetime; example: `2021-06-11T14:55:43.156.123+0200`.""" | ||
| dt = datetime.fromtimestamp(record.created, tz=self.LOCAL_TZ) | ||
| return dt.strftime(f"%Y-%m-%dT%H:%M:%S.{dt.microsecond / 1000}%z") |
Contributor
There was a problem hiding this comment.
There is no need to display microseconds.
Suggested change
| """Format datetime; example: `2021-06-11T14:55:43.156.123+0200`.""" | |
| dt = datetime.fromtimestamp(record.created, tz=self.LOCAL_TZ) | |
| return dt.strftime(f"%Y-%m-%dT%H:%M:%S.{dt.microsecond / 1000}%z") | |
| """Format datetime; example: `2021-06-11T14:55:43.156+0200`.""" | |
| dt = datetime.fromtimestamp(record.created, tz=self.LOCAL_TZ) | |
| return dt.strftime(f"%Y-%m-%dT%H:%M:%S.{int(dt.microsecond / 1000)}%z") |
Contributor
Author
There was a problem hiding this comment.
Thanks, @filipgolem, good catch! And I need also to remember about the leading 0's, in case the number of milliseconds is less than 100.
aef174b to
3ba6a65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #388
Example log line after the changes in this PR: