Skip to content

chore: bump stripe version to 14.19.0 - #705

Merged
underfisk merged 2 commits into
golevelup:masterfrom
fermentfan:chore/bump-stripe
Mar 6, 2024
Merged

chore: bump stripe version to 14.19.0#705
underfisk merged 2 commits into
golevelup:masterfrom
fermentfan:chore/bump-stripe

Conversation

@fermentfan

Copy link
Copy Markdown
Contributor

I noticed my local build fails due to the version conflict. I didn't try it out locally yet so I wonder if there is more work involved than just bumping it?

@fermentfan

Copy link
Copy Markdown
Contributor Author

Seems like the CI/CD is a bit flaky? It failed due to a timeout in a test and locally everything works as expected. Can somebody help me out by retriggering it?

@underfisk
underfisk merged commit 5de70ae into golevelup:master Mar 6, 2024
@fermentfan
fermentfan deleted the chore/bump-stripe branch March 6, 2024 19:52
@mhmdjaw

mhmdjaw commented Mar 16, 2024

Copy link
Copy Markdown

When is this going to be released? The latest version (0.6.5) is still using stripe v11.

@underfisk

Copy link
Copy Markdown
Collaborator

@WonderPanda Is it possible to have a major release for Stripe package?

@WonderPanda

Copy link
Copy Markdown
Collaborator

@WonderPanda Is it possible to have a major release for Stripe package?

I just tried to do a release but Stripe isn't set up for a major release yet:

Changes:
 - @golevelup/nestjs-stripe: 0.6.5 => 0.6.6
 - @golevelup/ts-jest: 0.4.0 => 0.5.0
 - @golevelup/ts-vitest: 0.4.0 => 0.5.0

With the current setup with Conventional Commit there needs to be a commit message that indicates a breaking change in order for the major version to get bumped

@oldschoolbg

Copy link
Copy Markdown

Just wondering if there has been any movement on getting this released?

:)

@fermentfan

Copy link
Copy Markdown
Contributor Author

Is all we need really just a commit? If so I will open a PR :D

@fermentfan

Copy link
Copy Markdown
Contributor Author

I hope it works that way? @WonderPanda @underfisk #714

WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
* chore: bump stripe version to 14.19.0
* fix: bump default Stripe API version

BREAKING CHANGE: Updates the underlying stripe dependency

---------

Co-authored-by: Dennis von der Bey <fermentfan@users.noreply.github.com>
WonderPanda pushed a commit that referenced this pull request Apr 10, 2024
* chore: bump stripe version to 14.19.0
* fix: bump default Stripe API version

BREAKING CHANGE: Updates the underlying stripe dependency

---------

Co-authored-by: Dennis von der Bey <fermentfan@users.noreply.github.com>
@WonderPanda

Copy link
Copy Markdown
Collaborator

This is published as version 0.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants