Skip to content

Some routing parameter can be provided multiple times#146

Merged
golles merged 1 commit intomainfrom
parameter-can-be-provided-multiple-times
May 26, 2025
Merged

Some routing parameter can be provided multiple times#146
golles merged 1 commit intomainfrom
parameter-can-be-provided-multiple-times

Conversation

@golles
Copy link
Copy Markdown
Owner

@golles golles commented May 26, 2025

Proposed change

The APIs handle lists differently, mostly as a comma-separated string, but these fields in the routing API need to repeat, therefore we need to specify a serialize function, in this case, the built-in list

Breaking change

The following fields are now lists:

  • CalculateLongDistanceEVRouteParams: sectionType, avoid and vehicleLoadType
  • CalculateReachableRouteParams: avoid and vehicleLoadType
  • CalculateRouteParams: sectionType, avoid and vehicleLoadType

Checklist:

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@golles golles added the enhancement New feature or request label May 26, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@c6291be). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main      #146   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        41           
  Lines           ?      2287           
  Branches        ?         0           
========================================
  Hits            ?      2287           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link
Copy Markdown

@golles golles merged commit 81e73f9 into main May 26, 2025
20 checks passed
@golles golles deleted the parameter-can-be-provided-multiple-times branch May 26, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant