Skip to content

Don't automatically close the provided session#166

Merged
golles merged 2 commits intomainfrom
improve-sessions
Jun 6, 2025
Merged

Don't automatically close the provided session#166
golles merged 2 commits intomainfrom
improve-sessions

Conversation

@golles
Copy link
Copy Markdown
Owner

@golles golles commented Jun 6, 2025

Proposed change

When a session is provided to one of the APIs, it shouldn't be automatically closed. The idea here is that the session can be used for several APIs or even within an application with other clients.

Breaking change

Provided sessions need to be closed manually when done.

Checklist:

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@golles golles added enhancement New feature or request breaking-change labels Jun 6, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e50d5c5) to head (82ce0d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         2290      2292    +2     
=========================================
+ Hits          2290      2292    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@golles golles enabled auto-merge (squash) June 6, 2025 09:56
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 6, 2025

@golles golles merged commit d3af771 into main Jun 6, 2025
17 checks passed
@golles golles deleted the improve-sessions branch June 6, 2025 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant