Skip to content

Use a generic type parameter for this function instead of a "TypeVar": python:S6796#6

Merged
golles merged 4 commits intomainfrom
python-S6796
Nov 30, 2024
Merged

Use a generic type parameter for this function instead of a "TypeVar": python:S6796#6
golles merged 4 commits intomainfrom
python-S6796

Conversation

@golles
Copy link
Copy Markdown
Owner

@golles golles commented Sep 26, 2024

Proposed change

Fix for https://sonarcloud.io/project/issues?issueStatuses=OPEN%2CCONFIRMED&id=golles_tomtom-apis-python&open=AZIrQLoV5phnTGAYh_q2

Breaking change

Checklist:

  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (22cb587) to head (8346f16).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         2254      2253    -1     
=========================================
- Hits          2254      2253    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@golles
Copy link
Copy Markdown
Owner Author

golles commented Sep 26, 2024

VSC (dev container, locally) doesn't look entirely happy with this yet, other return type arrows are white. However it doesn't show any error or curly line underneath, so maybe this is just the way to show generic return type?

Scherm­afbeelding 2024-09-26 om 19 32 35

@sonarqubecloud
Copy link
Copy Markdown

@golles golles merged commit 3bc3b0e into main Nov 30, 2024
@golles golles deleted the python-S6796 branch November 30, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant