-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
When a user has tag.gpgSign set to true in their global or local git config, running align tag hangs indefinitely. This is because GPG-signed tags are annotated tags, which require a message. Without a -m flag, git opens an editor to collect the tag message. Since align captures stdout and stderr into buffers (bytes.Buffer), the subprocess has no TTY, so the editor has nowhere to display and hangs forever.
Steps to Reproduce
- Enable GPG tag signing: git config --global tag.gpgSign true
- Run align tag -v
- Observe the output stops after printing the "directories" header and never completes
Expected Behavior
The command should either complete successfully or fail with a clear error message.
Suggested Fixes
- Fail loudly: Detect tag.gpgSign in git config before running and exit with a clear error message explaining the incompatibility, rather than hanging silently.
- Support annotated signed tags: Pass -m (or a configurable message) so that signed/annotated tags can be created without requiring an editor.
- Add a --no-sign flag: Allow users to override their git config by passing --no-sign through to the underlying git tag command.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels