feat:scroll top to each structure route#8
Merged
megatank58 merged 1 commit intogominima:mainfrom Feb 15, 2022
booleanrecep:scroll-top
Merged
feat:scroll top to each structure route#8megatank58 merged 1 commit intogominima:mainfrom booleanrecep:scroll-top
megatank58 merged 1 commit intogominima:mainfrom
booleanrecep:scroll-top
Conversation
|
✔️ Deploy Preview for gominima ready! 🔨 Explore the source changes: 59b9b0f 🔍 Inspect the deploy log: https://app.netlify.com/sites/gominima/deploys/620aad8549d4530008eeddcf 😎 Browse the preview: https://deploy-preview-8--gominima.netlify.app/ |
Contributor
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason:
As a reader I want to go top when I click a new
STRUCTURESpageActual behavior
On each
STRUCTURESpage scroll position is previous page's scroll position. If previous one was bottom of page then the actual page's scroll position is also bottom.What's changed
Any new page of
STRUCTURESstarts from top or scroll goes smoothly to top