fix: support external_account workload identity, add tests#2120
Merged
Conversation
matt0x6F
reviewed
May 12, 2026
| } | ||
| var credType google.CredentialsType | ||
| switch keyType.Type { | ||
| case "service_account": |
Contributor
There was a problem hiding this comment.
Should we use the actual type from the package here?
Member
Author
There was a problem hiding this comment.
good point. I gave it another shot, now supporting all types that would work.
matt0x6F
approved these changes
May 12, 2026
Contributor
matt0x6F
left a comment
matt0x6F
left a comment
There was a problem hiding this comment.
Gave a nit-pick, otherwise looks good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem I am trying to address?
Resolve #2119
How is the fix applied?
Support all credential types, cover
service_accountandexternal_accountwith tests.What GitHub issue(s) does this PR fix or close?
Fixes #2119