Skip to content
This repository was archived by the owner on Dec 9, 2018. It is now read-only.

Conversation

@btracey
Copy link
Member

@btracey btracey commented Dec 2, 2014

The old implementation of dgbmv was written in column-major style and had a few bugs. This writes it as row-major and adds a more robust test suite

The old implementation of dgbmv was written in column-major style and had a few bugs. This writes it as row-major and adds a more robust test suite
@btracey
Copy link
Member Author

btracey commented Dec 2, 2014

Please review this before #26 . I'll fix that once this is through.

@btracey btracey mentioned this pull request Dec 2, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+1.63%) when pulling fb08479 on fixdgbmv into 33f78a2 on master.

@btracey
Copy link
Member Author

btracey commented Dec 2, 2014

The comments on the top of #26 will be helpful in understanding the banded layout (they can be added when #26 gets added).

@btracey
Copy link
Member Author

btracey commented Dec 2, 2014

@kortschak

@coveralls
Copy link

Coverage Status

Coverage increased (+1.75%) when pulling 65cc414 on fixdgbmv into 33f78a2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.75%) when pulling 65cc414 on fixdgbmv into 33f78a2 on master.

@btracey btracey mentioned this pull request Dec 2, 2014
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kortschak
Copy link
Member

LGTM

btracey added a commit that referenced this pull request Dec 8, 2014
Fixed implementation of dgbmv and added tests.
@btracey btracey merged commit 4106a55 into master Dec 8, 2014
@btracey btracey deleted the fixdgbmv branch December 8, 2014 04:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants