This repository was archived by the owner on Apr 26, 2019. It is now read-only.
Conversation
0a4cd39 to
c7e2b40
Compare
9b575cc to
fd82995
Compare
Member
Author
|
This is ready for some review. Current issues are:
PTAL |
Member
Author
|
ping |
encoding/dot/dot_test.go
Outdated
Member
Author
There was a problem hiding this comment.
Good catch. That should not be there.
For reference, all this comes from this and playing around.
Member
|
I think it LGTM. |
Member
Author
|
PTAL for the documentation wording. I guess we can clean up the code at a later stage. It's reasonably readable, but I do think it could be improved upon. |
Member
There was a problem hiding this comment.
I like that this is stated explicitly.
Member
|
Much better now. LGTM. |
Updates #9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the package handles our basic graph types without any problem, but there are features in DOT that we can use (the additional interfaces do this - though they are not yet tested), e.g. subgraphs.When this has been iterated over, I will write a DOT parser to do the unmarshaling (this has some hairy bits that I'm still thinking about, but it's less of a concern - I just want something to make our packages a bit more friendly for visualisation).
@gonum/developers