This repository was archived by the owner on Apr 26, 2019. It is now read-only.
Conversation
c0747d2 to
6ad639a
Compare
Member
|
Code reuse and the information returned from Sort() are a good reason to use TarjanSCC. It would be really nice if this eventually ended up in a "topo" package. LGTM |
Member
Author
|
I have made minor changes - explicit statement of sort order and reversal of the order provided by TarjanSCC. I'll merge, but let me know if you disagree and I'll revert those. |
Contributor
|
Already merged, but seems good to me too On Mon, Jun 8, 2015 at 10:11 PM, Dan Kortschak notifications@github.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #78.
The naming might be contentious. The thinking is that TarjanSCC and this will end up in the
structurepackage (that I am now thinking should be calledtopofor shortness) - the contents of which might look something like it does in api-explore.We could just do a DFS toposort, but I think the value of being able to provide a reason for failure is worth any additional computational cost. The maintenance cost is 0, since we already need to look after TarjanSCC anyway.
@gonum/developers PTAL