This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add dlacn2 #38
Merged
Add dlacn2 #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This function is very iterative and so hard to test directly, and there's no cgo function to compare to. However, when this is merged along with the other two current PRs, they will all be called by Dgecon which we can test against cgo. |
Member
|
Ugh, that fortran spaghetti is horrible. LGTM |
Member
Author
|
Yep. The original FORTRAN was worse. |
Member
|
I meant the NETLIB 3.5 code - yours is good.
|
Member
|
Oops, isave should be a *[3]int or be returned, the mutations you are doing are not visible externally. Sorry I missed that.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.