This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add Dlanxx routines to lapack64 interface. #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Needed for computing condition numbers also. |
lapack64/lapack64.go
Outdated
Member
There was a problem hiding this comment.
Above you say there's a panic, but here you don't. What is our system?
Member
Author
There was a problem hiding this comment.
I think it should be self evident that the enum-like types need to be one of the valid values. If the function is restricted to a subset of them, then it should be documented. Sound good?
Member
Author
There was a problem hiding this comment.
Oh, missed the point. I'm adding the panic to the comments. We do it everywhere so far.
Member
|
LGTM |
btracey
added a commit
that referenced
this pull request
Sep 11, 2015
Add Dlanxx routines to lapack64 interface.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.