This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add Dlasrt #60
Merged
Add Dlasrt #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
Can we do this by a normal sort and then a simple slice reverse function written here? That avoids the double interface resolution that what's here costs.
Member
Author
There was a problem hiding this comment.
Sure. I thought this was the idiomatic code based on the example.
Member
There was a problem hiding this comment.
See what the performance difference is?
Member
Author
There was a problem hiding this comment.
Can we leave it as is now and re-assess when we have the functions that call it in context? This way we have a better guess on typical sizes.
Member
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.