This repository was archived by the owner on Nov 24, 2018. It is now read-only.
Add dorgqr and tests, update dorg2r tests, and fix cgo dorgqr #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@kortschak Would you mind taking a look? There must be another indexing error, but I can't find it. I hacked the values of nb and nx so that the blocked code can be reached with smaller matrices. |
native/dorgqr.go
Outdated
Member
|
I can't see anything other than the two things above. Neither of them fix the problem. |
Member
Author
|
Bleh. Sad times. |
Member
Author
|
Tests now pass, and cgo comment updated. PTAL. |
Member
Author
|
Actually, the algorithms are virtually identical, so I'm going to include the lq version in this as well. |
Member
Author
|
Okay. Pushed. PTAL. |
Member
|
LGTM |
Member
Author
|
Failures do not seem related to this PR and tests pass locally. |
btracey
added a commit
that referenced
this pull request
Oct 28, 2015
Add dorgqr and tests, update dorg2r tests, and fix cgo dorgqr
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.