Adddorgbr #76
Adddorgbr #76
Conversation
|
This consistent green is lovely. |
There was a problem hiding this comment.
The fortran equivalent of this is awful.
|
Shhhh don't jinx it. |
native/dorgbr.go
Outdated
There was a problem hiding this comment.
Set work[0] = 1 before return?
|
LGTM, but as always please wait for @vladimir-ch. |
There was a problem hiding this comment.
This seems to be an editing leftover.
There was a problem hiding this comment.
I was referring to the ... computed by Dgebrd computed from the decomposition Dgebrd. ... part.
There was a problem hiding this comment.
Ah, sorry, I'll fix when I get a chance. Thanks!
On Dec 11, 2015 8:34 PM, "Vladimír Chalupecký" notifications@github.com
wrote:
In cgo/lapack.go
#76 (comment):@@ -542,6 +543,47 @@ func (impl Implementation) Dgetrs(trans blas.Transpose, n, nrhs int, a []float64
clapack.Dgetrs(trans, n, nrhs, a, lda, ipiv32, b, ldb)
}+// Dorgbr generates one of the matrices Q or P^T computed by Dgebrd
+// computed from the decomposition Dgebrd. See Dgebd2 for the description ofI was referring to the ... computed by Dgebrd computed from the
decomposition Dgebrd. ... part.—
Reply to this email directly or view it on GitHub
https://github.com/gonum/lapack/pull/76/files#r47427005.
|
LGTM |
No description provided.