This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Conversation
kortschak
force-pushed
the
capped
branch
2 times, most recently
from
435da5f to
8d526f9
Compare
mat64/matrix_test.go
Outdated
Member
There was a problem hiding this comment.
Maybe these should just be "flatten: no row".
Member
Author
There was a problem hiding this comment.
It's not an issue with flatten though. I want the message to be to either the author of the test that they wrote a bad test (or to an unfortunate client that got code through a mistake in review that it isn't their fault).
Member
|
LGTM besides minor nit. |
* Panic on ragged input or rowless data. * Build data slice that has exact cap - this is what NewDense does, so we should match that. Also add code to TestRowColView that should have been added as TestRowColViewFullCap in #110.
Member
Author
|
@btracey PTAL |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change catches a bug in (*Dense).ColView that will be fixed with a PR to be merged later today (#110).