This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Conversation
Member
Author
|
Am I reading the code properly on e? |
mat64/eigen.go
Outdated
Member
What do you mean? |
Member
Author
|
Are the values of e actually in positive negative pairs? Do these values need sorting like in D(), or is as is fine? |
Member
|
Not sure. |
Member
|
Making a quick test on the test data (change the sign -2 on L26 in the tests), what you are doing is right. |
mat64/eigen.go
Outdated
Member
|
LGTM after comments addressed. |
btracey
added a commit
that referenced
this pull request
Jan 28, 2016
Begin transformation of Eigen structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.