This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Conversation
Member
|
Why do LQ and QR panic if not full rank? I see that there is a possibility to check if not full rank, just wondering what the rule is. |
mat64/matrix_test.go
Outdated
Member
There was a problem hiding this comment.
Because of the special casing in solve, it would be nice to have the m > n and m < n cases as well.
Contributor
|
Does https://github.com/gonum/matrix/blob/master/mat64/lu.go#L224 need to be changed as well? |
Member
Author
|
That code is not called when the matrix is singular if using the Solve func. If the client is using the LU type directly, they can check IsSingular and deserve a panic if they don't. |
Member
|
LGTM |
kortschak
added a commit
that referenced
this pull request
Nov 3, 2014
Return ErrSingular for singular matrix solves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #30.