This repository was archived by the owner on Dec 10, 2018. It is now read-only.
Fix docs in conv and cmat128.Conjugate.At#334
Merged
vladimir-ch merged 2 commits intomasterfrom Feb 12, 2016
Merged
Conversation
cmat128/matrix.go
Outdated
| // matrix, that is, row j and column i of the Matrix field. | ||
| func (t Conjugate) At(i, j int) complex128 { | ||
| return t.Matrix.At(j, i) * complex(1, -1) | ||
| return cmplx.Conj(t.Matrix.At(j, i)) |
Member
There was a problem hiding this comment.
I don't this this is worth the import, but it could be more sensibly written as
v := t.Matrix.At(j, i)
return complex(real(v), -imag(v))
which is just what cmplx.Conj does.
Member
Author
There was a problem hiding this comment.
In fact this is what I originally had there but then I noticed that cmplx.Conj exists without checking what it does internally. Done.
Member
There was a problem hiding this comment.
Presumably at a later date we will need to import cmplx, we can use that then.
Member
|
LGTM after change to Conjugate.At body. Thank you. |
vladimir-ch
force-pushed
the
doc-fixes
branch
from
e55313b to
203bc76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.