This repository was archived by the owner on Nov 23, 2018. It is now read-only.
Updated BFGS to use Symmetric #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
It's a bit slower at the moment, but it'll speed back up when gonum/matrix#100 is merged. |
bfgs.go
Outdated
Member
|
LGTM |
Removed outdated TODO
Member
Author
|
@jonlawlor this looks like the same error we were seeing earlier with Travis |
Member
Author
|
Sorry, this is a real failure I guess. I think the partial pass was because I merged to matrix and here very close. Looking into it. |
Member
Author
|
Nothing was wrong with this commit. The symmetric implementation in Inner is incorrect. Fixing now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.