Skip to content

[bot] Merge master/ea3d46ae into rel/dev #1058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yenkins-admin merged 2 commits into from
Jun 3, 2025
Merged

[bot] Merge master/ea3d46ae into rel/dev #1058

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c42f63
feat: add description to workspace
hkad98 Jun 3, 2025
ea3d46a
Merge pull request #1057 from hkad98/jkd/workspace-description
hkad98 Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gooddata-sdk/gooddata_sdk/catalog/workspace/declarative_model/workspace/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ def change_wdf_refs_id(self, mapping: dict[str, str]) -> None:
class CatalogDeclarativeWorkspace(Base):
id: str
name: str
description: Optional[str] = None
model: Optional[CatalogDeclarativeWorkspaceModel] = None
parent: Optional[CatalogWorkspaceIdentifier] = None
permissions: list[CatalogDeclarativeSingleWorkspacePermission] = attr.field(factory=list)
Expand Down
18 changes: 14 additions & 4 deletions gooddata-sdk/gooddata_sdk/catalog/workspace/entity_model/workspace.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,21 @@ class CatalogWorkspace(Base):
id: str = attr.field(init=False, default=attr.Factory(lambda self: self.workspace_id, takes_self=True))
name: str
parent_id: Optional[str] = attr.field(default=None)
description: Optional[str] = attr.field(default=None)

@classmethod
def from_api(cls, entity: dict[str, Any]) -> CatalogWorkspace:
ea = entity["attributes"]
er = entity.get("relationships")
return cls(workspace_id=entity["id"], name=ea["name"], parent_id=safeget(er, ["parent", "data", "id"]))
return cls(
workspace_id=entity["id"],
name=ea["name"],
parent_id=safeget(
er,
["parent", "data", "id"],
),
description=ea.get("description"),
)

def to_api(self) -> JsonApiWorkspaceInDocument:
kwargs = dict()
Expand All @@ -36,12 +45,13 @@ def to_api(self) -> JsonApiWorkspaceInDocument:
data=JsonApiWorkspaceToOneLinkage(id=self.parent_id, type="workspace")
)
)
attributes_dict = {"name": self.name}
if self.description:
attributes_dict["description"] = self.description
return JsonApiWorkspaceInDocument(
data=JsonApiWorkspaceIn(
id=self.id,
attributes=JsonApiWorkspaceInAttributes(
name=self.name,
),
attributes=JsonApiWorkspaceInAttributes(**attributes_dict),
**kwargs,
)
)
Loading