fix(docs): install SDK packages in V2 deploy for legacy builder#1433
Merged
hkad98 merged 1 commit intogooddata:masterfrom Mar 16, 2026
Merged
fix(docs): install SDK packages in V2 deploy for legacy builder#1433hkad98 merged 1 commit intogooddata:masterfrom
hkad98 merged 1 commit intogooddata:masterfrom
Conversation
fix(docs): install SDK packages in V2 deploy for legacy builder Older release branches lack griffe_builder.py, so the build falls back to json_builder.py which imports gooddata_sdk and gooddata_pandas at runtime. The V2 workflow only installed script-requirements.txt, causing ModuleNotFoundError for branches using the legacy path. JIRA: trivial risk: nonprod
Mara3l
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Old release branches don't have
griffe_builder.pyormethod_page_renderer.pyin their git tree. The build scripts checked for these files on the target branch before using them, even though they always ran the current branch's copies.For branches without
griffe_builder.py, the fallback wasjson_builder.pywhich does runtime imports ofgooddata_sdk/gooddata_pandas— causingModuleNotFoundErrorsince those aren't installed in the docs build env.For branches without
method_page_renderer.py, Hugo shortcodes (parameters-block,parameter) were left unprocessed. Their templates were removed in the griffe pipeline commit, so Hugo fails with "template for shortcode not found".Fix: Remove the conditional checks and always use
griffe_builder.py(static analysis, no imports) andmethod_page_renderer.py(replaces shortcodes with inline HTML) from the current branch. Both work on any branch's source code.