Skip to content

Allow boundParams to be also integers, booleans.#2

Merged
hazeledmands merged 2 commits into
goodeggs:masterfrom
jtomaszewski:master
Apr 1, 2014
Merged

Allow boundParams to be also integers, booleans.#2
hazeledmands merged 2 commits into
goodeggs:masterfrom
jtomaszewski:master

Conversation

@jtomaszewski

Copy link
Copy Markdown
Contributor

I just spent 1 hour thinking why my collection's array isn't being cached.

That was because:

  1. first I forgot (didn't know) to set resource's params like {id: '@id'}
  2. Then it appeared that only string values are being cached, but my id: values were integers, so they didn't cache at all.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@hazeledmands

Copy link
Copy Markdown
Contributor

Thanks for the awesome PR! You're right; the documentation for this project needs a lot of love.

hazeledmands pushed a commit that referenced this pull request Apr 1, 2014
Allow boundParams to be also integers, booleans.
@hazeledmands hazeledmands merged commit 266b776 into goodeggs:master Apr 1, 2014
@jtomaszewski

Copy link
Copy Markdown
Contributor Author

Thanks for merging this! The project is great and the only thing it needs right now is a lot of stars and watchers on GitHub ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants