Use Librato 'counters' in addition to 'gauges'#37
Closed
mmoskal wants to merge 3 commits intogoodeggs:masterfrom
Closed
Use Librato 'counters' in addition to 'gauges'#37mmoskal wants to merge 3 commits intogoodeggs:masterfrom
mmoskal wants to merge 3 commits intogoodeggs:masterfrom
Conversation
Author
|
After some experimenting, this is not as useful as I thought - librato expects the client to keep track of the counter, not only post increments. |
Author
|
Re-opened, and updated to make it work in non-distributed setting. |
|
Thanks @mmoskal ! |
Contributor
|
@mmoskal @garnold I think #27 / #40 (which just landed) eliminates the need for this. It might still be nice to offer users the ability to choose gauges or counters for increment, but it seems like counters should be the default (and now they are). I'm going to close this until we hear folks need the choice. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the module reports
increment()as Librato gauges, but librato also has a counter type (http://dev.librato.com/v1/post/metrics). This patch adds optioncounters:trueto reportincrement()calls as counters.