sanitize the name of the metric sent to timing() and increment()...#7
Merged
adborden merged 1 commit intogoodeggs:masterfrom Nov 18, 2014
Merged
sanitize the name of the metric sent to timing() and increment()...#7adborden merged 1 commit intogoodeggs:masterfrom
adborden merged 1 commit intogoodeggs:masterfrom
Conversation
… the rules used in librato's official statsd backend: https://github.com/librato/statsd-librato-backend/blob/dffece631fcdc4c94b2bff1f7526486aa5bfbab9/lib/librato.js#L146 . This should help avoid a number of scenarios where the client sends a bad request (due to a bad metric name) and the service is forced to 400. Also: hard-code the coffeescript version that is expected, because only a very specific version will not cause diffs across the codebase when the js files are built.
Contributor
Author
|
I believe this should fix #6 . Also, I created a Makefile locally that might be nicer than using npm (or maybe not if you like npm that much): ( just |
Contributor
|
this looks good... did you close it on accident or do you have something different coming? |
Contributor
Author
|
Yeah I must've closed it by accident. Duh :) I've been using this patch in production, and it works pretty well, so I think it's good to merge unless you have objections. |
adborden
pushed a commit
that referenced
this pull request
Nov 18, 2014
sanitize the name of the metric sent to timing() and increment()...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... with the rules used in librato's official statsd backend:
https://github.com/librato/statsd-librato-backend/blob/dffece631fcdc4c94b2bff1f7526486aa5bfbab9/lib/librato.js#L146
. This should help avoid a number of scenarios where the client sends a
bad request (due to a bad metric name) and the service is forced to 400.
Also: hard-code the coffeescript version that is expected, because only
a very specific version will not cause diffs across the codebase when
the js files are built.