Closed
Conversation
Contributor
|
Cool, thanks for doing this! Looks like we're going to be fixing coffee-script to 1.6.3 for now -- I had to fix the mocha command after resolving conflicts with master. Don't we need a build step to generate the js for packaging? |
Author
|
@adborden good catch. I'm not sure, maybe adding coffee-script as a dependency would solve it as well |
Contributor
|
I actually like that we test against the compiled JS -- we've had coffee compilation issues bite us before and this is a safeguard. Instead, we should be able to have coffee-script generate sourcemaps and ignore them in an npmignore file. I went ahead and did the work in 6025c7b ... sorry it took me so long to take a look at this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey ho,
We fixed your tests 😉 Testing the compiled version is unnecessary, and makes debugging way harder. So we added the missing switch to mocha and fixed some requirement issues.
cheers :)
HF & GL digga 👯
