Skip to content

fix tests#8

Closed
OleMchls wants to merge 1 commit intogoodeggs:masterfrom
Jimdo:fix_tests
Closed

fix tests#8
OleMchls wants to merge 1 commit intogoodeggs:masterfrom
Jimdo:fix_tests

Conversation

@OleMchls
Copy link

Hey ho,

We fixed your tests 😉 Testing the compiled version is unnecessary, and makes debugging way harder. So we added the missing switch to mocha and fixed some requirement issues.

cheers :)

HF & GL digga 👯
selfie-0

@adborden
Copy link
Contributor

Cool, thanks for doing this! Looks like we're going to be fixing coffee-script to 1.6.3 for now -- I had to fix the mocha command after resolving conflicts with master. Don't we need a build step to generate the js for packaging?

@OleMchls
Copy link
Author

OleMchls commented Dec 1, 2014

@adborden good catch. I'm not sure, maybe adding coffee-script as a dependency would solve it as well

@bobzoller
Copy link
Contributor

I actually like that we test against the compiled JS -- we've had coffee compilation issues bite us before and this is a safeguard. Instead, we should be able to have coffee-script generate sourcemaps and ignore them in an npmignore file.

I went ahead and did the work in 6025c7b ... sorry it took me so long to take a look at this.
--Bob

@bobzoller bobzoller closed this Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants