Skip to content

📦 chore: skill frontmatter に license 追記 + description を 1024 文字以内に#257

Merged
touyou merged 3 commits into
mainfrom
chore/skill-license-and-description
Apr 20, 2026
Merged

📦 chore: skill frontmatter に license 追記 + description を 1024 文字以内に#257
touyou merged 3 commits into
mainfrom
chore/skill-license-and-description

Conversation

@touyou

@touyou touyou commented Apr 20, 2026

Copy link
Copy Markdown
Member

Summary

gh skill publish --dry-run を走らせたときに出た 2 つの validation warning に対応。

Changes

license: Apache-2.0 を全 4 skill の frontmatter に追加

リポジトリ本体と同じ Apache-2.0。

description の長さ調整(≤ 1024 chars)

skill before after status
accessibility-checker 793 793 既に OK
add-sparkle-component 810 810 既に OK
change-sparkle-config 1184 954 ✂️ トリム
setup-sparkle-design 1166 880 ✂️ トリム

トリム方針:

  • 長い修飾(「Sparkle Design Theme Settings Figma プラグインが扱える範囲」→「Theme Settings Figma プラグインが扱える範囲」)を短縮
  • 重複気味の trigger 語彙を削減(主要トリガーは残す)
  • 日本語 + English の両並記は維持(Claude Code 等が両言語からトリガーできるため)

Dry-run 検証

$ cd .claude && gh skill publish --dry-run
warning  no active tag protection rulesets found. ...
Dry run complete. Use without --dry-run to publish.

license / description 関連のエラーは解消。

Publish 時の注意

gh skill publishskills/*/SKILL.md パターンを探すため、このリポジトリでは .claude ディレクトリで実行する必要があります。プロジェクトルートからだと .claude/skills/*/SKILL.md を拾えずに "no skills found" になります。

cd .claude
gh skill publish --dry-run   # validation only
gh skill publish             # interactive tagging + release
gh skill publish --tag v1.0.0  # 非対話で指定タグ

🤖 Generated with Claude Code

touyou and others added 2 commits April 20, 2026 11:33
GitHub 公式の `gh skill` コマンド(v2.90+、2026-04 リリース)がオープン Agent
Skills 仕様準拠で standards 的にも安定しつつあるため、README の skill 導入
手順を gh skill デフォルト + npx skills fallback に書き換える。gh の方が:

- GitHub 公式で spec が枯れる見込み
- タグ / SHA pin が可能(`skill@v1.2.0`)
- `gh skill preview` で install 前 inspect が標準
- `--all` 相当は対話 TUI で多選択

日英両方を同じ構成で更新。change-sparkle-config スキルも一覧に追加。

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
`gh skill publish --dry-run` が以下の 2 つを要求してきたため対応:

- **license フィールド必須**: 全 4 skill に `license: Apache-2.0` を追加
  (リポジトリ本体と同じ Apache-2.0)
- **description ≤ 1024 chars**: change-sparkle-config (1184→954) と
  setup-sparkle-design (1166→880) をトリム。他 2 skill (accessibility-checker
  793 / add-sparkle-component 810) は元々範囲内

トリム方針:
- 「Sparkle Design Theme Settings Figma プラグイン」→「Theme Settings Figma
  プラグイン」のように文脈で分かる修飾を短縮
- 重複的な trigger 例をスリム化(主要なものは残す)
- 日本語 + English の両並記は維持(トリガー認識のため)

検証:
  cd .claude && gh skill publish --dry-run
  → Dry run complete(エラー無し)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 20, 2026 02:50
@vercel

vercel Bot commented Apr 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sparkle-design Ready Ready Preview, Comment Apr 20, 2026 3:01am

Request Review

@coderabbitai

coderabbitai Bot commented Apr 20, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 992df7bc-3c49-4a9a-904e-ed0b847e5619

📥 Commits

Reviewing files that changed from the base of the PR and between 973bd63 and 0ccf89a.

📒 Files selected for processing (2)
  • README.en.md
  • README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • README.md

Walkthrough

スキルのマニフェストに license: Apache-2.0 を追加し、README(日本語・英語)で AI スキル導入手順を Vercel の npx skills add から GitHub CLI の gh skill を中心に置換。いくつかのスキル説明文を簡潔化・表現修正。

Changes

Cohort / File(s) Summary
スキルマニフェスト - ライセンス フィールド追加
.claude/skills/accessibility-checker/SKILL.md, .claude/skills/add-sparkle-component/SKILL.md, .claude/skills/change-sparkle-config/SKILL.md, .claude/skills/setup-sparkle-design/SKILL.md
各スキルの frontmatter に license: Apache-2.0 を追記。
スキル説明文・トリガー文言の更新
.claude/skills/change-sparkle-config/SKILL.md, .claude/skills/setup-sparkle-design/SKILL.md
説明文の語句/改行調整、トリガー例の簡潔化、範囲表現の修正(例: 初期セットアップ→初期導入等)。
インストール手順ドキュメント更新
README.en.md, README.md
導入手順を Vercel の npx skills add から GitHub CLI の gh skill install / gh skill preview / --agent 指定へ変更。npx をフォールバックとして併記。

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰✨ ライセンスを着せてぴょん、
CLIの道をぴょんぴょんと紡いで、
スキルは整い、指示はすっきり、
インストールの朝にジャンプ! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive PR 説明は、テンプレートの「概要」「変更内容」の要件を満たし、具体的な変更内容(license 追加、description トリム)と検証方法を詳述していますが、テンプレートで指定されている「動作確認」「セルフレビューリスト」セクションは記載されていません。 テンプレートの「動作確認」(lint、build、test)と「セルフレビューリスト」の該当項目を追加してください。ただし、ドキュメント変更主体の PR のため実施が困難な項目は明示的に不適用と記載する方法も検討ください。
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed タイトルは、skill frontmatter に license を追記し、description を 1024 文字以内に調整するという PR の主要な変更内容を明確に要約しており、リポジトリの変更との整合性が取れています。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/skill-license-and-description

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s published “skills” metadata to satisfy gh skill publish --dry-run validation warnings by adding an explicit license and keeping skill descriptions within the allowed length.

Changes:

  • Add license: Apache-2.0 to the frontmatter of all 4 skills under .claude/skills/*/SKILL.md.
  • Trim overly-long skill description frontmatter to be ≤ 1024 characters (notably for change-sparkle-config and setup-sparkle-design).
  • Update Japanese/English READMEs to document installation via the official gh skill command, with a fallback to Vercel’s skills CLI.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updates the “install as skill” instructions to use gh skill (with fallback instructions).
README.en.md Same as README.md, for English docs.
.claude/skills/setup-sparkle-design/SKILL.md Adds Apache-2.0 license frontmatter and trims description text.
.claude/skills/change-sparkle-config/SKILL.md Adds Apache-2.0 license frontmatter and trims description text.
.claude/skills/add-sparkle-component/SKILL.md Adds Apache-2.0 license frontmatter.
.claude/skills/accessibility-checker/SKILL.md Adds Apache-2.0 license frontmatter.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@README.md`:
- Around line 80-100: The README uses incorrect agent flag values in the gh
skill examples: replace any instance of "--agent gemini-cli" with "--agent
gemini", and remove or avoid suggesting "--agent copilot" (GitHub Copilot is the
default and not a documented --agent value); update the examples around the
lines showing "gh skill install goodpatch/sparkle-design ... --agent gemini-cli"
and "gh skill install goodpatch/sparkle-design setup-sparkle-design --agent
copilot" to use supported agents (e.g., "--agent claude-code", "--agent cursor",
"--agent codex", or "--agent gemini") or omit the flag to use Copilot by
default.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: eb06c45b-9b36-40a4-b256-ccc7f2ac692b

📥 Commits

Reviewing files that changed from the base of the PR and between 1709760 and 973bd63.

📒 Files selected for processing (6)
  • .claude/skills/accessibility-checker/SKILL.md
  • .claude/skills/add-sparkle-component/SKILL.md
  • .claude/skills/change-sparkle-config/SKILL.md
  • .claude/skills/setup-sparkle-design/SKILL.md
  • README.en.md
  • README.md

Comment thread README.md Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 973bd63fef

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread README.md
# setup-sparkle-design スキルだけを導入
npx skills add goodpatch/sparkle-design -s setup-sparkle-design
# setup-sparkle-design スキルだけを導入(推奨)
gh skill install goodpatch/sparkle-design setup-sparkle-design --agent claude-code

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Point gh skill install to a discoverable skill path

gh skill install discovers remote skills using the skills/*/SKILL.md convention (gh skill install manual), but this repository’s skill files are under .claude/skills/*/SKILL.md. With the command shown here, users installing from goodpatch/sparkle-design will get a “no skills found” error, so the new primary installation flow is non-functional until the repo exposes a skills/ path (or the docs use a supported alternative).

Useful? React with 👍 / 👎.

Comment thread README.md Outdated
```

導入後に「Sparkle Design を導入して」と依頼すると `setup-sparkle-design` スキルが発動し、プロジェクト状態に合わせて不足ステップだけ案内してくれます。`-a claude-code` / `-a codex` などで対象エージェントを指定することもできます。
導入後に「Sparkle Design を導入して」と依頼すると `setup-sparkle-design` スキルが発動し、プロジェクト状態に合わせて不足ステップだけ案内してくれます。`--agent` には `claude-code` / `copilot` / `cursor` / `codex` / `gemini-cli` などを指定できます。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use supported gh --agent values in the README

The agent names documented in this line do not match gh skill install’s accepted enum ({github-copilot|claude-code|cursor|codex|gemini|antigravity}). Following this guidance with --agent copilot or --agent gemini-cli will fail argument validation, so these values should be corrected to the canonical github-copilot and gemini identifiers.

Useful? React with 👍 / 👎.

- `--agent gemini-cli` → `--agent gemini`
- `--agent copilot` → `--agent github-copilot`
- 正式に対応している `antigravity` も列挙
- 非対話実行時のデフォルト (`github-copilot`) を明記

`gh skill install --help` の表記に合わせた修正。

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@touyou touyou merged commit 7cefa24 into main Apr 20, 2026
4 checks passed
@touyou touyou deleted the chore/skill-license-and-description branch April 20, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants