Skip to content

Fix genome match#17

Merged
samirelanduk merged 5 commits intomasterfrom
fix-genome-match
May 26, 2022
Merged

Fix genome match#17
samirelanduk merged 5 commits intomasterfrom
fix-genome-match

Conversation

@samirelanduk
Copy link
Copy Markdown
Contributor

This is the proposed fix for the genome switching issue we had. There are a few checks/changes that might be needed before merging:

  • Marc could you check the changes I made to primaryclipanalysis.nf? I basically took the pattern you used to get TRIMGALORE to work and applied it everywhere a channel had two inputs that needed to be kept in line with each other.
  • I’ve added a --method unique to DEDUP processes - I gather from Charlotte that this needs to be both generated from the file contents as well as being overridable, so this will need to be modified.
  • I also gather there are some CLIPPY changes to be made?

Comment thread subworkflows/ncrna.nf
Comment thread subworkflows/ncrna.nf
Comment thread subworkflows/primaryclipanalysis.nf Outdated
Comment thread subworkflows/primaryclipanalysis.nf Outdated
Copy link
Copy Markdown
Contributor

@marc-jones marc-jones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the changes to subworkflows/ncrna.nf which changes the functionality, the rest looks good. I didn't anticipate the issues with having different references running simultaneously!

@samirelanduk samirelanduk merged commit ed7b794 into master May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants