fix: prevent division by zero in sampling when temperature is 0.0#573
Open
ChiragTrivedi06 wants to merge 1 commit intogoogle-deepmind:mainfrom
Open
fix: prevent division by zero in sampling when temperature is 0.0#573ChiragTrivedi06 wants to merge 1 commit intogoogle-deepmind:mainfrom
ChiragTrivedi06 wants to merge 1 commit intogoogle-deepmind:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
76b5cfe to
f8dc797
Compare
f8dc797 to
4ea7dcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Numerical Stability Guard for Sampling Methods
Problem
Currently, the RandomSampling, TopkSampling, and TopPSampling classes perform a direct division by the
temperatureparameter. Whentemperature=0.0, this leads to a division-by-zero error, causing JAX/XLA to produceNaNorInflogits and crashing the sampling pipeline.Proposed Changes
Instead of a hard switch to a separate Greedy implementation, this PR introduces a threshold-based guard within the sampling classes. This ensures numerical stability while maintaining a unified API for consumers.
Key Implementation Details:
scaled_logits = logits if self.temperature < 1e-6 else logits / self.temperatureacross all sampling methods.temperaturehyperparameter.Technical Rationale
Verification
NaNlogits or XLA errors._sampling_test.pywith cases for near-zero and zero temperature.Closes #562