Fix MinGW stack flag syntax and Python binding crashes#3083
Merged
copybara-service[bot] merged 1 commit intogoogle-deepmind:mainfrom Feb 18, 2026
Merged
Conversation
mmossg
approved these changes
Feb 11, 2026
Ashutosh0x
force-pushed
the
fix/mingw-linker-stack
branch
from
c453320 to
975d8c0
Compare
Ashutosh0x
added a commit
to Ashutosh0x/mujoco
that referenced
this pull request
Feb 11, 2026
Collaborator
|
I think to make import/copybara happy, the cmake/MujocoLinkOptions.cmake changes also need to be replicated in simulate/cmake/MujocoLinkOptions.cmake and sample/cmake/MujocoLinkOptions.cmake. |
Ashutosh0x
force-pushed
the
fix/mingw-linker-stack
branch
from
04c7d09 to
e588948
Compare
Contributor
Author
|
@mmossg Done, thanks! Replicated the changes to simulate and sample folders. |
- Detect linker type (lld-link vs ld) and use the appropriate stack flag: /STACK:16777216 for lld-link, --stack,16777216 for MinGW ld - Filter out stack-related flags from Python binding modules to prevent crashes when loading MuJoCo as a DLL in Python Fixes google-deepmind#3011
Ashutosh0x
force-pushed
the
fix/mingw-linker-stack
branch
from
e588948 to
50349dc
Compare
mmossg
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request addresses issues with linker flag syntax on MinGW and prevents crashes when loading MuJoCo as a Python module on Windows.
Changes
Fixes #3011