Fix: google grounding is not working#105
Merged
Plytas merged 2 commits intogoogle-gemini-php:mainfrom May 12, 2025
Merged
Conversation
…alMetadata are nullable
Collaborator
|
Thanks for this @maximetassy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google grounding is not working
Problem
Google Grounding tool does not work with model >= 2.0.
The implementation use
googleSearchtool which does not seem to be the way google wants to go with this tool.As stated here, we should use
google_searchwith an empty object.Also, some attributes of GroundingMetadata are nullable in the documentation and the app crash if they are not defined.
Solution