Remove sequence binding

[scidomino]

Summary

Key.sequence was only used in one redundant binding ('\x18') which is removed in this PR.

Details

Also changes KeyBinding.key to be mandatory.

Related Issues

For #14425

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @scidomino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the key binding system by completely removing the sequence property. This change simplifies the KeyBinding interface, standardizes how key presses are matched, and cleans up related configuration and documentation generation, leading to a more consistent and maintainable input handling mechanism.

Highlights

• KeyBinding Interface Simplification: The sequence property has been removed from the KeyBinding interface, making the key property mandatory for all key binding definitions.
• Standardized Key Matching Logic: The internal key matching mechanism has been refactored to exclusively rely on the key property, eliminating the previous dual-path matching that considered both key and sequence.
• Updated Default Bindings and Tests: Default key bindings and their corresponding test cases have been updated to remove any sequence-based definitions, ensuring consistency with the new KeyBinding structure.
• Documentation Generation Streamlining: The script responsible for generating key binding documentation has been simplified by removing all logic related to formatting and processing sequence properties.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Size Change: -271 B (0%)

Total Size: 23 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23 MB	-271 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}

[gemini-code-assist]

Code Review

This pull request effectively removes the sequence property from key bindings, simplifying the configuration and matching logic. The changes are consistently applied across the codebase, including type definitions, default bindings, matching logic, tests, and documentation generation scripts. The key property is now mandatory, which makes the bindings more explicit. This is a good refactoring that improves code clarity and maintainability. I found no issues with the implementation.