Patch #16730 into v0.25.0 preview

[chrstnb]

Summary

Details

Related Issues

How to Validate

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refining the TypeScript configuration for the packages/core module. By introducing specific baseUrl and paths settings, the changes aim to improve internal module resolution, making imports more efficient and maintainable across the project.

Highlights

• TypeScript Configuration Update: The tsconfig.json file in packages/core has been updated to include baseUrl and paths configurations, enhancing module resolution within the project.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a TypeScript path alias to the core package to allow it to reference itself using its package name. While this can be convenient, it introduces a significant risk of runtime errors because the path alias is not resolved by the Node.js runtime by default. My review includes a comment explaining this issue in detail and suggests removing the alias to prevent potential MODULE_NOT_FOUND errors. It's safer to use relative paths for imports within the same package.

[gemini-code-assist]

Adding a paths alias for a package to reference itself can lead to runtime errors. The paths option in tsconfig.json is a compile-time feature that is not understood by the Node.js runtime by default. This means that while the code will compile successfully, it will fail at runtime with a MODULE_NOT_FOUND error when it tries to import from @google/gemini-cli-core from within the package itself.

This creates a fragile setup that is hard to debug. For robust module resolution, it's better to use relative paths for intra-package imports. If path aliases are a requirement, they must be accompanied by a runtime resolution mechanism, such as the Node.js imports field in package.json.

To prevent potential runtime failures, it's recommended to remove this path alias.

    "types": ["node", "vitest/globals"]

[github-actions]

Size Change: -2 B (0%)

Total Size: 23 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23 MB	-2 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}