Emit correct newline type return #17331
Conversation
Summary of ChangesHello @scidomino, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a regression where fast returns, particularly when buffering, were no longer correctly interpreted as newlines. By explicitly setting modifier keys ( Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue where buffered fast returns, such as those from pasting text, are incorrectly treated as submissions instead of newlines. The change correctly modifies the keypress event to represent a shift+return by setting shift: true and explicitly resetting other modifiers to false. This ensures that pasted newlines are handled as newlines within the input, which is the desired behavior. The implementation is straightforward and effectively addresses the described bug. The change looks correct.
|
Size Change: +130 B (0%) Total Size: 23.2 MB ℹ️ View Unchanged
|
gemini-cli
bot
added
the
status/need-issue
|
/patch preview |
|
✅ Patch workflow(s) dispatched successfully! 📋 Details:
🔗 Track Progress: |
# Conflicts: # packages/cli/src/ui/contexts/KeypressContext.test.tsx
|
🚀 Patch PR Created! 📋 Patch Details:
📝 Next Steps:
🔗 Track Progress: |
|
🚀 Patch Release Started! 📋 Release Details:
⏳ Status: The patch release is now running. You'll receive another update when it completes. 🔗 Track Progress: |
|
✅ Patch Release Complete! 📦 Release Details:
🎉 Status: Your patch has been successfully released and published to npm! 📝 What's Available:
🔗 Links: |
2 participants
Summary
When buffering fast returns, emit them as
shift+returninstead of shiftless.Details
We were previously accidentally relying on
name: '',to make this not be treated as a return. When I fixed that toname: 'return',that caused this to stop being treated as a newline.How to Validate
Copy paste text with a newline in an editor that doesn't support bracketed paste.
Pre-Merge Checklist