Skip to content

Conversation

@chrstnb
Copy link
Contributor

@chrstnb chrstnb commented Jan 26, 2026

Summary

Prevent error when updating user-scoped extensions.

Details

Since we're also fetching workspace settings even for user scoped settings, we need to pass in the cwd.

Related Issues

Fixes #17579

How to Validate

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run
      • npx
      • Docker
      • Podman
      • Seatbelt
    • Windows
      • npm run
      • npx
      • Docker
    • Linux
      • npm run
      • npx
      • Docker

@chrstnb chrstnb requested a review from a team as a code owner January 26, 2026 21:01
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a configuration issue within the CLI's extension management. It ensures that when user-scoped extensions are being updated, the system correctly identifies the current working directory, preventing errors that previously arose from this missing context.

Highlights

  • Extension Configuration Fix: Resolved an error that occurred when updating user-scoped extensions by ensuring the current working directory (cwd) is correctly passed to configuration functions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request effectively addresses the configuration error by ensuring that process.cwd() is consistently passed as the workspaceDir argument to getScopedEnvContents. While this resolves the immediate issue, the review comments highlight a potential for confusion regarding the workspaceDir parameter's optionality, suggesting a re-evaluation of its signature or more explicit conditional handling to improve maintainability and clarity for future development.

@github-actions
Copy link

github-actions bot commented Jan 26, 2026

Size Change: +38 B (0%)

Total Size: 23.4 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 23.3 MB +38 B (0%)
./bundle/sandbox-macos-permissive-closed.sb 1.03 kB 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-closed.sb 3.29 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B

compressed-size-action

@gemini-cli gemini-cli bot added the area/extensions Issues related to Gemini CLI extensions capability label Jan 26, 2026
@scidomino scidomino enabled auto-merge January 26, 2026 22:15
@scidomino scidomino added this pull request to the merge queue Jan 26, 2026
Merged via the queue into main with commit 4662972 Jan 26, 2026
24 of 25 checks passed
@scidomino scidomino deleted the cb/fixbug branch January 26, 2026 22:39
yunaseoul pushed a commit that referenced this pull request Jan 27, 2026
Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/extensions Issues related to Gemini CLI extensions capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gemini extensions config missing workspace directory

2 participants