-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Fix extensions config error #17580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extensions config error #17580
Conversation
Summary of ChangesHello @chrstnb, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a configuration issue within the CLI's extension management. It ensures that when user-scoped extensions are being updated, the system correctly identifies the current working directory, preventing errors that previously arose from this missing context. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request effectively addresses the configuration error by ensuring that process.cwd() is consistently passed as the workspaceDir argument to getScopedEnvContents. While this resolves the immediate issue, the review comments highlight a potential for confusion regarding the workspaceDir parameter's optionality, suggesting a re-evaluation of its signature or more explicit conditional handling to improve maintainability and clarity for future development.
|
Size Change: +38 B (0%) Total Size: 23.4 MB ℹ️ View Unchanged
|
Co-authored-by: Tommaso Sciortino <sciortino@gmail.com>
Summary
Prevent error when updating user-scoped extensions.
Details
Since we're also fetching workspace settings even for user scoped settings, we need to pass in the cwd.
Related Issues
Fixes #17579
How to Validate
Pre-Merge Checklist