feat: Fix flickering in iTerm + scrolling + performance issues.#181
Merged
NTaylorMullen merged 1 commit intomainfrom Apr 26, 2025
Merged
feat: Fix flickering in iTerm + scrolling + performance issues.#181NTaylorMullen merged 1 commit intomainfrom
NTaylorMullen merged 1 commit intomainfrom
Conversation
NTaylorMullen
force-pushed
the
ntm/b.412716309.411450097
branch
from
5aaa9c4 to
cb9d8a6
Compare
Comment on lines
42
to
44
Contributor
There was a problem hiding this comment.
I'm surprised we don't have a lint rule for these sort of shenanigans.
Collaborator
Author
There was a problem hiding this comment.
lol you no like?
packages/cli/src/ui/types.ts
Outdated
Contributor
There was a problem hiding this comment.
question: what's the different between gemini and gemini_content?
Collaborator
Author
There was a problem hiding this comment.
Totally fair question, I tried to put some details in GeminiMessageContent.tsx
NTaylorMullen
force-pushed
the
ntm/b.412716309.411450097
branch
2 times, most recently
from
5f218dc to
f1281bc
Compare
- Refactors history display using Ink's <Static> component to prevent flickering and improve performance by rendering completed items statically. - Introduces ConsolePatcher component to capture and display console.log, console.warn, and console.error output within the Ink UI, addressing native handling issues. - Introduce a new content splitting mechanism to work better for static items. Basically when content gets too long we will now split content into multiple blocks for Gemini messages to ensure that we can statically cache larger pieces of history. Fixes: - https://b.corp.google.com/issues/411450097 - https://b.corp.google.com/issues/412716309
NTaylorMullen
force-pushed
the
ntm/b.412716309.411450097
branch
from
f1281bc to
a6a2eb2
Compare
NTaylorMullen
added a commit
that referenced
this pull request
Apr 27, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: #181
NTaylorMullen
commented
Apr 27, 2025
| } | ||
|
|
||
| export const InputPrompt: React.FC<InputPromptProps> = ({ onSubmit }) => { | ||
| const [value, setValue] = React.useState(''); |
NTaylorMullen
added a commit
that referenced
this pull request
Apr 27, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: #181
keithballinger
pushed a commit
that referenced
this pull request
Jun 13, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: #181
elminramazanov
pushed a commit
to elminramazanov/claimfront
that referenced
this pull request
Jun 25, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: google-gemini/gemini-cli#181
viridivn
pushed a commit
to viridivn/gemini-cli
that referenced
this pull request
Jun 29, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: google-gemini#181
happy-dev100
added a commit
to happy-dev100/gemini
that referenced
this pull request
Sep 19, 2025
- The push for these changes didn't make it through.... Just doing a quick fix here which should have been in: google-gemini/gemini-cli#181
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: