fix- windows: add shell: true for spawnSync to fix EINVAL with .cmd editors

[zackoch]

… files

Summary

Fix EINVAL error when spawning .cmd files (e.g. code.cmd) on Windows for external editor vscode.

Adds shell: process.platform === 'win32' to spawnSync options in openInExternalEditor, so batch files execute correctly without Node.js security restrictions.

Details

Node.js (v18+) blocks direct execution of .cmd/.bat files via spawnSync without shell: true due to security changes.

This patch simply applies shell: true only on Windows,.
Locally tested on win 11 with vscode as preferred editor and now ctrl+x opens editor without crashing.

Related Issues

Fixes #17376

How to Validate

1. set preferred editor to vscode
2. gemini
3. press crtl+x
4. yahtzee

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @zackoch, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue affecting Windows users who utilize external editors configured as .cmd or .bat files. By adjusting the spawnSync options to explicitly use a shell on Windows, it ensures that these editors launch correctly, preventing application crashes and improving the user experience on that platform.

Highlights

• Windows Compatibility: Resolved an EINVAL error on Windows when attempting to open external editors (like VS Code) that are .cmd files, by conditionally adding "shell: true" to spawnSync options.

Changelog

• packages/cli/src/ui/components/shared/text-buffer.ts
  • Added "shell: process.platform === 'win32'" to the options passed to spawnSync to enable correct execution of .cmd and .bat files on Windows.

Activity

• The pull request introduces a fix for a known issue (Fixes Ctrl + X throws an error in CLI Version 0.25.1 (after update) in Windows 10 and doesn't open any editor #17376).
• The author has locally tested the fix on Windows 11 with VS Code as the preferred editor.
• The author has updated the pre-merge checklist, marking Windows validation as complete for npm run and npx.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue on Windows where external editors defined by .cmd files, such as VS Code, would fail to launch due to an EINVAL error. The fix, which involves conditionally setting the shell: true option for spawnSync on the Windows platform, is appropriate and well-targeted. This allows the operating system's shell to properly handle batch file execution, resolving the bug as described. The change is sound and I have no further recommendations.