Fix layout rounding.

[gundermanc]

Summary

Checks in a Gemini-hypothesized root cause for "Exceeded max update depth" issue in render.

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run
    • npx
    • Docker
    • Podman
    • Seatbelt
  • Windows
    • npm run
    • npx
    • Docker
  • Linux
    • npm run
    • npx
    • Docker

[gemini-code-assist]

Summary of Changes

Hello @gundermanc, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses visual inconsistencies in the UI by ensuring that calculated element heights are rounded to whole numbers, preventing potential sub-pixel rendering artifacts. Additionally, it improves the logic for handling pending include directories by clearing them earlier in the trust dialog workflow.

Highlights

• Layout Height Rounding: Implemented Math.round for height calculations in AppContainer.tsx and MaxSizedBox.tsx to prevent sub-pixel rendering issues and ensure consistent UI element sizing.
• Trust Dialog Logic Refinement: Refactored the useIncludeDirsTrust hook to clear pending include directories immediately upon the creation of the MultiFolderTrustDialog, rather than after its completion.

Changelog

• packages/cli/src/ui/AppContainer.tsx
  • Ensured controlsHeight is set to a rounded integer value by applying Math.round to fullFooterMeasurement.height.
• packages/cli/src/ui/components/shared/MaxSizedBox.tsx
  • Applied Math.round to entry.contentRect.height within the ResizeObserver to prevent fractional height values.
• packages/cli/src/ui/hooks/useIncludeDirsTrust.tsx
  • Relocated the config.clearPendingIncludeDirectories() call to execute before the MultiFolderTrustDialog is rendered, ensuring pending directories are cleared proactively.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix layout rounding issues by using Math.round() on height values obtained from measureElement and ResizeObserver. These changes in AppContainer.tsx and MaxSizedBox.tsx are good practice to prevent layout instability from fractional pixel values. However, the change in useIncludeDirsTrust.tsx introduces a bug by prematurely clearing a list of pending directories, which could lead to data loss if the user cancels the operation. I've left a comment with a suggestion to fix this.

[github-actions]

Size Change: +35 B (0%)

Total Size: 23.9 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	23.9 MB	+35 B (0%)
./bundle/sandbox-macos-permissive-closed.sb	1.03 kB	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-closed.sb	3.29 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B

_{compressed-size-action}